Fix incorrect times in time evolution solutions
#244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
- Coverage 94.40% 93.55% -0.85%
==========================================
Files 31 31
Lines 2268 2266 -2
==========================================
- Hits 2141 2120 -21
- Misses 127 146 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
albertomercurio
approved these changes
Sep 29, 2024
albertomercurio
pushed a commit
to albertomercurio/QuantumToolbox.jl
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
timesof different time evolution solutions are basically obtained fromsol.t.However, the length of
sol.tactually depends on the keyword argumentsaveat.To make it consistent with the docstrings, and also align with
QuTiP, I putt_lintop = (..., times = t_l, ...), and then pass it to different time evolution solutions withsol.prob.p.times.After this PR, the type of
sol.timesare all the same asVector{<:Real}for different time evolution solutions, and the length should be equal to the inputtlist.